refactor: move java-common-protos, java-iam, java-showcase to top level#12839
refactor: move java-common-protos, java-iam, java-showcase to top level#12839
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the IAM library configuration to iam-policy, adds an api_id, and introduces a new common-protos library entry in generation_config.yaml. It also adjusts the parent POM relative path in java-common-protos/pom.xml. Feedback focuses on maintaining alphabetical order for library entries, updating the display name for the IAM Policy library for consistency, and ensuring consistent string formatting by removing unnecessary quotes in the configuration file.
chingor13
changed the title
|
The showcase-clirr check fails as we are moving the showcase source and it's comparing against head (which doesn't have the new location) |
|
|
6 participants
Currently, the hermetic code generator can only move files to top level folders. Rather than changing the generator, we will move the generated code to the top level to also make it compatible with librarian.
Other fixes:
Towards #12735
Towards #12702